I'm in the middle of reviewing a developers code. This amused me…
Code
var url=''; if(document.getElementById('file'+number)) { url=document.getElementById('file'+number).value; } else { if (filename!='') { url=filename; } }
because it is exactly equivalent in behaviour to…
Code
var url=filename; [...]
I'm in the middle of reviewing a developers code. This amused me…
Code
var url='';
if(document.getElementById('file'+number))
{
url=document.getElementById('file'+number).value;
}
else
{
if (filename!='')
{
url=filename;
}
}
because it is exactly equivalent in behaviour to…
Code
var url=filename;
if(document.getElementById('file'+number))
{
url=document.getElementById('file'+number).value;
}
I saw this straight away, and then I thought "hey, that's actually quite a complex optimisation". Are any programmers reading? I'd be interested if this is the kind of thing other people notice, or am I just fussier about things?
